You could shift those parts from the current loop towards the outer loop that do not depend on the
variables of the current loop (= are constant in that loop). This avoids unnecessary re-computation and
might slightly improve performance.
use warnings;
use Win32::OLE;
use Win32::OLE qw(in with);
use Win32::OLE::Const "Microsoft Excel"
my $yes = "yes"; #-- moved: constant for both loops
for ($begincol;$begincol<$totcol;$begincol++) {
my $app = $sheet2->Cells(3,$begincol)->{'Text'}; #-- moved: consta
+nt for next loop
for ($beginrow;$beginrow<$maxrows;$beginrow++) {
my $cap = $Sheet2->Cells($beginrow,5)->{'Text'};
#-- moved out of inner loop: my $app = $sheet2->Cells(3,$begi
+ncol)->{'Text'};
#-- moved out of both loops: my $yes = "yes";
if (index($app, $cap) != -1) {
$Sheet->Cells($beginrow,$begincol)->{Value} = $asis;
}
}
$beginrow = 7;
}
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|