As haukex has already pointed out, it's probably best to avoid eval in this case as it could be manipulated to run arbitary Perl code in your example.
hippo has also made a valid suggestion about using the ternary if conditional to make the code easier to read.
Personally, I'd use both of these suggestions, add in the use of say rather than print when appropriate and move the display prompt and return input into a separate function, but that might be over-engineering this learning exercise.
Putting it all together gives the following:
use strict;
use warnings;
use 5.016;
sub prompt_read {
print shift;
chomp( $_ = <STDIN> );
return $_;
}
say "RegEx Engine 1.0\n________________";
my $str = prompt_read("Gimme a string: ");
my $pattern = prompt_read("Gimme a RegEx: ");
say $str =~ /$pattern/ ? "Yes!" : "No!";
say "kthxbye";
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|