I'm glad to see that had, at least some, appeal.
It was, as stated, somewhat "primitive".
Expanding upon that a little, the following is more generally what I had in mind,
which removes duplicate code and separates the "decoding engine (code)"
(putting it into Decoupled.pm).
The expanded script (note there's no change to the original while loop or input data):
#!/usr/bin/env perl -l
use strict;
use warnings;
use lib '.';
use Decoupled qw{
preprocess_complex_message
handle_generic_message
};
my %decode_type = (
A => sub {
handle_generic_message(
A => preprocess_complex_message($_[0])
)
},
B => sub {
handle_generic_message(B => $_[0])
},
);
while (<DATA>) {
chomp;
my ($type, $msg) = split /\s+/, $_, 2;
my $decoded = $decode_type{$type}->($msg);
print $decoded;
}
__DATA__
B message B1
A more complex message A1
B message B2
The Decoupled module:
package Decoupled;
use strict;
use warnings;
use Exporter 'import';
our @EXPORT_OK = qw{
preprocess_complex_message
handle_generic_message
};
sub preprocess_complex_message {
$_[0] =~ /more complex (.*)/; $1
}
sub handle_generic_message {
sprintf "Do Type%s stuff with '%s'", @_
}
1;
The new output:
Do TypeB stuff with 'message B1'
Do TypeA stuff with 'message A1'
Do TypeB stuff with 'message B2'
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.