There shall be no else after return/die/croak. Ever!
sub leonardo{
my $n = shift;
if($n == 0 || $n == 1){
return 1;
}
else{
return leonardo($n-2)+leonardo($n-1)+1;
}
}
SHould be rewritten to either
sub leonardo {
my $n = shift;
$n == 0 || $n == 1 and
return 1;
return leonardo ($n - 2) + leonardo ($n - 1) + 1;
}
or using a ternary
sub leonardo {
my $n = shift;
$n == 0 || $n == 1 ? 1 : leonardo ($n - 2) + leonardo ($n - 1) + 1
+;
}
with your personal preference to whitespace and indentation of course.
The else in an if is there to give alternative code in a control flow where the code after the if/else contruct is executed for both branches. As the if branch ends with a return statement, immediatly exiting the routine, the code after if/else is never executed and only written for the else branch making the code harder to read and maintain.
Enjoy, Have FUN! H.Merijn
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|