Beefy Boxes and Bandwidth Generously Provided by pair Networks
XP is just a number
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??

Hello QuillMeantTen, and welcome to the Monastery!

Since this is a learning exercise, I want to comment on your use of C-style for loops. For example, from sub heapify:

for(my $i = $start; $i < leonardo($order);$i++){ print "$$tab_ref[$i]\n"; }

As a general rule, whenever you have a C-style for loop in which the reinitialisation expression increments a variable by one, you should re-cast it as a Perl-style foreach loop instead:

for my $i ($start .. leonardo($order) - 1) { print "$$tab_ref[$i]\n"; }

Or, even better, put it on a single line by making the foreach a statement modifier:

print "$$tab_ref[$_]\n" for $start .. leonardo($order) - 1;

— which has the added advantage of simplifying the code by removing a variable declaration.

Not only is a Perl foreach loop intrinsically faster than its C-style equivalent; in this case you get a significant extra benefit in efficiency, because the subroutine call to leonardo($order) is made only once. Here’s a longer example to emphasise the point:

use strict; use warnings; my $x = 5; for (my $i = 0; $i < bar($x); $i++) { print "for loop: $i\n"; } print "----------\n"; for my $j (0 .. bar($x) - 1) { print "foreach loop: $j\n"; } sub bar { my $y = shift; print "bar($y)\n"; return $y; }

Output:

19:23 >perl 1378_Smoothsort.pl bar(5) for loop: 0 bar(5) for loop: 1 bar(5) for loop: 2 bar(5) for loop: 3 bar(5) for loop: 4 bar(5) ---------- bar(5) foreach loop: 0 foreach loop: 1 foreach loop: 2 foreach loop: 3 foreach loop: 4 19:23 >

Of course, this works only because the value returned by leonardo($order) doesn’t change (because $order isn’t changed in the body of the loop).

Another point to note: recursive functions like sub leonardo can often be significantly streamlined by memoization. This is explained in Chapter 3 of Higher-Order Perl by Mark Jason Dominus, which is available for free from http://hop.perl.plover.com/. See also the module Memoize (also by MJD).

Update: Fixed off-by-one error in foreach loops, thanks to AnomalousMonk (twice!).

Hope that helps,

Athanasius <°(((><contra mundum Iustus alius egestas vitae, eros Piratica,


In reply to Re: Smoothsort by Athanasius
in thread Smoothsort by QuillMeantTen

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others lurking in the Monastery: (5)
As of 2024-03-28 08:45 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found