Avoiding SQL injection is simple. Use DBI placeholders.
Instead of concatenating your values into your string, put ? there, and then place the values in ->execute(...).
You have structured your code around concatenating strings, so I would first replace the sqlSelect</p> with something like:
sub sqlSingleRow( $sql, @placeholders ) {
my $sth = $dbh->prepare( $sql );
$sth->execute(@placeholders);
# Do you really get only ever a single row back?
my (@r)=$c->fetchrow();
$c->finish();
return @r;
}
... and then use that routine like:
my $sql_cat = <<'SQL';
select ref_categorie
from categorie_libelle_langue
, libelle
, langue
from ref_categorie
where libelle.libelle = ?
AND categorie_libelle_langue.ref_libelle = libelle.id_libel
+le
AND categorie_libelle_langue.ref_langue = langue.id_langue
+AND langue.key = ?
SQL
my ($cat) = sqlSingleRow($sql_cat, $category, $lang );
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|