Ah. Well, I don't think I could improve what I have much. What you don't see is that these two separate subroutines are called by separate AJAX functions under differing conditions, and that they each have a non-overlapping functionality along with what certainly does appear to be redundant at first glance. Note the comments given to each function, and note that they differ in terms of the password handling as well. While the actual DB query is essentially the same, updating a password, it is vetted in two distinct ways: one is an administrative reset of another member's password, while the other is the user changing his or her own password. Neither of these functions will happen more than rarely.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|