Beefy Boxes and Bandwidth Generously Provided by pair Networks
No such thing as a small change
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??
"identify the mistake in my code"

There are a multitude. For a start there are a bunch of variables that seem to be global to the code you give, which is (kinda) OK, but including something to show that those variables are supposed to be global to the outer for loop would be smart ($workbook1, $worksheet, @cellA, ...).

Some variables are clearly not declared correctly ($cellA, $row, ...). $r isn't declared and it's scope isn't obvious.

Your indentation is all over the place. You need to turn most of your if statements inside out:

for my $col ($col_min = 0) { if ($appssheet eq $appsshhetname) { my $cell = $worksheet1->get_cell($row, 0); ... } }

should be:

for my $col ($col_min = 0) { next if $appssheet ne $appsshhetname; my $cell = $worksheet1->get_cell($row, 0); ... }

Because of all the above issues (except maybe the if statements stuff) it isn't possible to check the logic of your code with any certainty. Perhaps you need to turn on strictures and tighten up the scope of your variables as a first step?

Optimising for fewest key strokes only makes sense transmitting to Pluto or beyond

In reply to Re: Unable to compare 2 arrays from 2 separate columns of separate sheets. by GrandFather
in thread Unable to compare 2 arrays from 2 separate columns of separate sheets. by chandantul

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others goofing around in the Monastery: (1)
As of 2024-04-25 19:41 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found