Tip:
$opt->{'encoding'} ? $opt->{'encoding'} : 'utf-8'
is more idiomatically/simply written as
$opt->{encoding} || 'utf-8'
Tip:
if ( length($line) > 0 || $opt->{'empty'} && $opt->{'empty'} eq 'fill'
+ ) {
$final_line = $prefix . $line . $suffix;
}
elsif ( $opt->{'empty'} && $opt->{'empty'} eq 'blank' ) {
$final_line = '';
}
elsif ( $opt->{'empty'} && $opt->{'empty'} eq 'undefined' ) {
$final_line = undef;
}
else {
next;
}
could be simplified to
my $empty = $opt->{empty} || '';
...
if ( length($line) || $empty eq 'fill' ) {
$final_line = $prefix . $line . $suffix;
}
elsif ( $empty eq 'blank' ) {
$final_line = '';
}
elsif ( $empty eq 'undefined' ) {
$final_line = undef;
}
else {
next;
}
But I'd personally setup some variables beforehand.
my $empty = $opt->{empty} || '';
my $trim_empty = !$empty;
my $keep_empty = $empty eq 'fill';
my $empty_replacement = $empty eq 'blank' ? '' : undef;
...
if ( length($line) || $keep_empty ) {
push @array, $prefix . $line . $suffix;
}
elsif ( !$trim_empty ) {
push @array, $empty_replacement;
}
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.