Walter_T: To expand on the first point made by haukex, re-declaring a global (e.g., our) variable isn't just unnecessary, it's completely useless. The only thing it will do is to generate a warning message if warnings are enabled – which, IMHO, they should always be.
c:\@Work\Perl\monks>perl -le
"use strict;
use warnings;
;;
our $x = 'x before loop';
print qq{before loop: '$x'};
;;
for my $i (1 .. 2) {
our $x = 'x in loop';
print qq{in loop: iteration $i: '$x'};
}
;;
print qq{after loop: '$x'};
"
"our" variable $x redeclared at -e line 1.
(Did you mean "local" instead of "our"?)
before loop: 'x before loop'
in loop: iteration 1: 'x in loop'
in loop: iteration 2: 'x in loop'
after loop: 'x in loop'
As the warning message suggests, you may have been thinking of local, which will actually do something in this situation.
c:\@Work\Perl\monks>perl -le
"use strict;
use warnings;
;;
our $x = 'x before loop';
print qq{before loop: '$x'};
;;
for my $i (1 .. 2) {
local $x = 'x in loop';
print qq{in loop: iteration $i: '$x'};
}
;;
print qq{after loop: '$x'};
"
before loop: 'x before loop'
in loop: iteration 1: 'x in loop'
in loop: iteration 2: 'x in loop'
after loop: 'x before loop'
But even when used in this way, globals should, I believe, be avoided. In general, use globals only for good, well-understood reasons.
Give a man a fish: <%-{-{-{-<
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.