If you add use warnings; to the head of your script, Perl will tell you that the opening of the while loop:
while ($i = 1) {
contains a logic error: it re-initialises the variable to 1 on each loop iteration. In fact, this loop would benefit from a complete re-write:
use strict;
use warnings;
my $c;
for (my ($valid, $try) = (0, 1); !$valid; ++$try)
{
print "Enter the range of the array (try $try):\n";
chomp($c = <STDIN>);
if ($c =~ /^\d+$/)
{
print "You have entered a valid range: $c\n";
$valid = 1;
}
elsif ($try < 3)
{
print "The input is invalid, please enter digits only\n";
}
else
{
print "No valid array range entered, exiting\n";
exit;
}
}
print "Continuing...\n";
This is one of the unusual cases in which a C-style for loop is useful in Perl. Please note:
- I have also added use strict; and declared all variables as lexicals with my. The amount of time this will save you down the track far outweighs the (very small) extra effort required.
- In future, please put <code> ... </code> tags around your code, to make it readable.
- When asking a question (as opposed to commenting on someone else’s answer), it’s usually better to open a new thread.
Hope that helps,
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|