Beefy Boxes and Bandwidth Generously Provided by pair Networks
Perl Monk, Perl Meditation
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??

Consider this refactored version of your Perl script. (It hasn't been tested at all.)

use strict; use warnings; use autodie qw( open close ); use open qw( :encoding(UTF-8) :std ); my %terms_in; # Hash of hash of terms in each file my $terms_file = 'array.txt'; open my $fh1, '<', $terms_file; while (my $record = <$fh1>) { my ($file, $term) = $record =~ m/^(\S+)\s+(\S+)/; $terms_in{ $file }{ $term } = 1; } close $fh1; FILE: for my $file (keys %terms_in) { open my $fh2, '<', $file; while (my $line = <$fh2>) { for my $term (keys %$terms_in{ $file }) { if (index $line, $term) { print "Term $term found in file $file\n"; # Don't search terms that have already been found... delete $terms_in{ $file }{ $term }; } } # Don't keep searching file once all terms have been found... if (scalar keys %$terms_in{ $file } == 0) { close $fh2; next FILE; } } close $fh2; } # At this point, what remains in %terms_in are all the terms that # were not found in their respective files, which might be useful. exit 0;

In reply to Re: Passing variable to if statement by Jim
in thread Passing variable to if statement by PeachCityDude

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others chilling in the Monastery: (4)
As of 2024-04-23 16:58 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found