It is not really clear what you are trying to achieve here. Your variable naming convention really does not make it clear what the desired output is.
You do some undefined check on $user_name and put the results in $no_name which you do not use. You push the city value into an array but try to print as a scalar, perhaps a hash of arrays is not the appropriate data structure to use.
Here is a slightly modified version of your code that uses a check_name sub and correctly displays the array contents. Hopefully this gives you a clue as to how to modify your code to achieve your goal.
use strict;
use warnings;
my $result = data();
foreach my $key ( keys %$result ) {
my $value = join(',', @{$result->{$key}});
print "User Name = $key - City: $value\n";
}
sub data {
#db code stuff
my $sql = [
{ username => 'abc', city=> 'foo' },
{ username => 'def', city=> 'bar' },
{ username => 'ghi', city=> 'goo' },
{ username => 'jkl', city=> 'car' },
{ username => 'm-n-o', city=> 'car' },
];
#...
my %no_name_found;
if ( @$sql ) {
for ( @$sql ) {
my $user_name = $_->{'username'};
my $city = $_->{'city'} || '';
if ( check_name( $user_name ) ) {
push @{ $no_name_found{ $user_name } }, $city;
}
}
}
return \%no_name_found;
}
sub check_name {
my $name = shift;
if ( $name =~ /^\w+$/ ) {
return $name;
}
}
Output
User Name = def - City: bar,bas
User Name = abc - City: foo
User Name = jkl - City: car
User Name = ghi - City: goo
If you still are having problems please provide a more detailed description of what you are trying to achieve, include all relevant subs and a sample of input data and how you want it to display on output.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
|
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.
|
|