VincentK:
A couple suggestions:
- For player.pm and gameroom.pm, you're allowing the export of the method names, but the method names don't need to be exported. If they were class and/or utility functions (i.e. functions not needing an object reference) then I can see where exporting the name can be useful. But I don't see any value to exporting these method names.
- In the main game script, you're using subroutine prototypes, but they're not helpful in these cases. You may want to review the prototypes section of perldoc perlsub.
Otherwise, it looks pretty good.
...roboticus
When your only tool is a hammer, all problems look like your thumb.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|
