Beefy Boxes and Bandwidth Generously Provided by pair Networks
Pathologically Eclectic Rubbish Lister
 
PerlMonks  

comment on

( #3333=superdoc: print w/replies, xml ) Need Help??

A small suggestion would be adding one more slot to the buffer and using some perl idiomcyncracies (sic) to reduce the need to manipulate the buffer in the inner loop:

#!/usr/bin/env perl use Modern::Perl; my $lb = 3; # lookback my $match = qr/\wiz/; my @buff; while ($buff[$.%($lb+1)] = ($_ = <DATA>)) { my $lbi = ($.+1)%($lb+1); # lookback index print $buff[$lbi] if defined $buff[$lbi] and /$match/; } __DATA__ foo bar baz biz buz goo car caz ciz cuz

P.S. Thanks for optimizing my two line circular linked list declaration to zero lines! ;-)

P.P.S. Too bad: Yours is, IMHO, the best answer to the OP, but is buried in this subthread.

EDIT Just reviewed this code and saw that I forgot defined! This opens the door for error if the lookback line is empty or a zero. While I was at it, I changed the emphasis from the lookback line itself to the index that finds it; plus, no more relying on side effects in the conditional.

For the three of y'all who upvoted the earlier incarnation, the original code is below. One line was deleted, one line added, one line changed.

my $lbl; # lookback line while ($buff[$.%($lb+1)] = ($_ = <DATA>)) { print $lbl if $lbl = $buff[($.+1)%($lb+1)] and /$match/; }

In reply to Re^3: Printing line before matching expression by jaredor
in thread Printing line before matching expression by rm

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.
  • Log In?
    Username:
    Password:

    What's my password?
    Create A New User
    Chatterbox?
    and the web crawler heard nothing...

    How do I use this? | Other CB clients
    Other Users?
    Others contemplating the Monastery: (7)
    As of 2021-02-25 11:22 GMT
    Sections?
    Information?
    Find Nodes?
    Leftovers?
      Voting Booth?

      No recent polls found

      Notices?