open (FILE," $htmlfile") || die "Cannot open HTML file for parsing!: $
+!\n";
while(<FILE>) {
$content="$content$_\n";
}
close(FILE);
This construct is not ideal. You are interpolating the variable $content into a new string for every line. You should use concatenation and just append to the string:
while(<FILE>) {
$content .= "$_\n";
}
But what you are doing now is slurping in the whole file and adding an extra newline at the end of each line (for which I see absolutely no reason). The same thing can be achieved by undefing $/ like this:
{
local $/; # undefs $/ for this block of code only
open (FILE," $htmlfile") || die "Cannot open HTML file for parsing!:
+ $!\n";
$content = <FILE>; # reads in whole file
$content =~ s/\n/\n\n/g; # if really necessary to duplicate newlines
close(FILE);
}
-- Hofmator
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|