Beefy Boxes and Bandwidth Generously Provided by pair Networks
laziness, impatience, and hubris
 
PerlMonks  

Re: Re: Use of uninitialized value in pattern match (m//)

by wolis (Scribe)
on Feb 10, 2004 at 03:37 UTC ( [id://327807]=note: print w/replies, xml ) Need Help??


in reply to Re: Use of uninitialized value in pattern match (m//)
in thread Use of uninitialized value in pattern match (m//)

Ah yes.. $tmp2 is defined with a:
my $tmp2 = $2;
So maybe because $2 from my previous regex is undef, $tmp2 becomes undef resulting in the warning.. this makes sense.

So to fix this would the 'best' solution to wrap my code in an if block:

if($tmp2){ if($tmp2 =~ m/'/){ ...

I thought 'in pattern match' literally meant within the m//

As for me escaping a single quote.. I get paranoid and end up escaping everything in my regex that is not an Alphanumeric just in case :-)

___ /\__\ "What is the world coming to?" \/__/ www.wolispace.com

Replies are listed 'Best First'.
Re: Re: Re: Use of uninitialized value in pattern match (m//)
by davido (Cardinal) on Feb 10, 2004 at 05:54 UTC
    So maybe because $2 from my previous regex is undef, $tmp2 becomes undef resulting in the warning.. this makes sense.

    So to fix this would the 'best' solution to wrap my code in an if block:

    if($tmp2){ if($tmp2 =~ m/'/){ ...

    You shouldn't be even using $2 if the match that was supposed to give it a value failed. You must rework your script's logic so that $2 is only being used if the match that loaded it succeeded.

    In fact, it's dangerous to simply assume that if $2 is undefined if the previous match failed. Such is not always the case. It's even dangerous to assume anything about $2 unless you KNOW that the previous match succeeded. Take a look at the following contrived snippet:

    use strict; use warnings; my $string = "Hello world!"; $string =~ m/(H\w+)\s(\w+)/; # This match succeeds. print $2, "\n"; $string =~ /(\d)(\d)/; # This match fails. print $2, "\n";

    And the output is:

    world world

    This tells us that $2, which gains a value during the first match, retains that value even though the second match failed. In other words, even though you gave the possibility for $2 to gain a new value in the second match, it retained the original value because the second match failed.

    That means that it is unreliable to just assume $2 is going to be undef if the most recent match failed, because it could possibly be holding some value from a previous pattern match.

    Go back to the drawing board with regards to your program's logic. ;)

    Now in regards to how to avoid an "undefined" warning, just check for definedness before doing anything with it. Please note, this solution is a stopgap measure, and won't fix the underlying bug in your script. I am providing this only because you essentially asked how to do something only if a scalar holds a defined value:

    my $tmp2 = $var; # Because of bad logic we don't know # if $var is defined, thus don't know if # $tmp2 is defined. if ( defined( $tmp2 ) and $tmp2 =~ m/regex/ ) { # Do your stuff. }

    Enjoy! I hope all this helps...


    Dave

Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://327807]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others sharing their wisdom with the Monastery: (6)
As of 2024-04-23 17:32 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found