Beefy Boxes and Bandwidth Generously Provided by pair Networks
Perl-Sensitive Sunglasses
 
PerlMonks  

(kudra: what about Craft?) RE: RE: Code Review section, anyone?

by kudra (Vicar)
on Sep 14, 2000 at 20:07 UTC ( #32492=note: print w/replies, xml ) Need Help??


in reply to RE: Code Review section, anyone?
in thread Code Review section, anyone?

I think Seekers is quite different from what was proposed for the code review section.

Seekers:
the code doesn't work; the poster is stuck. Post the minimal example and describe errors.
Code Review:
the code works, but the poster wants to know if there's a way to improve a function's efficiency, or if there are some bugs in the module that s/he hasn't seen, or if there's a pitfall in the program s/he didn't notice.

That said, I think Review is more or less like Craft.

See the description of the various sections. I get the impression that snippets and catacombs could easily be used for polished pieces of (snippets and standalone programs respectively) code (polished modules belong at CPAN of course). The code in these sections should be good enough for someone to use. It might actually be nice to have these sections moderated, allowing only code that passed review to be found in these sections.

Craft, on the other hand, is a place to show off code. If something's on display, it's going to get comments and critique...at least that's how I see it.

Update: Merlyn, I agree that it's good to have it clear that people will critique. I just think a new section would be redundant. If Craft is what I think it is (and if not, what is it for?), it would certainly benefit from a clearer description, and possibly even from being renamed to Review.

  • Comment on (kudra: what about Craft?) RE: RE: Code Review section, anyone?

Replies are listed 'Best First'.
RE: (kudra: what about Craft?) RE: RE: Code Review section, anyone?
by merlyn (Sage) on Sep 14, 2000 at 20:10 UTC
    Craft, on the other hand, is a place to show off code. If something's on display, it's going to get comments and critique...at least that's how I see it.
    But you perhaps are a mature programmer, someone who understands that putting stuff out there is going to get critique. I'm worried about a repeat of a couple of mistakes I made in the past here, where someone is posting a snippet "because it's way cool, dude" and not for critique, and then I critique it.

    I want a place where it's clear from the get go that code will get shredded in that area. So the newbies with fragile egos will stay away, but the people who understand what having a good code critique will treasure.

    -- Randal L. Schwartz, Perl hacker

      i think that operating on the default assumption that Craft is for 'showing off' works rather well, and people who want a critique could ask for it when posting to Craft.

      optionally, why not check the poster's home node for mail, and send 'em a private critique rather than a public one, so if the ego gets shattered, it's still within the privacy of the home/cube/whatever.

      criticism is great - when it's expected. and someone who posts code and writes 'l00k itz k3wl d00d' probably doesn't really want to have errors pointed out -- even if they're deserved.

RE: (3) Code Review section, anyone? (Code Catacombs already moderated, I think)
by ybiC (Prior) on Oct 25, 2000 at 06:28 UTC
    I think that Code Catacombs is already moderated in some manner.   I've submitted a small handful of minor scripts, one of which actually appears there.   Mind you, I'm not complaining - just hope to learn enough at PM to eventually tweak or rewrite the others to warrant inclusion.   8^)
        cheers,
        Don
        striving for Perl Adept
    A reply falls below the community's threshold of quality. You may see it by logging in.

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://32492]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others cooling their heels in the Monastery: (3)
As of 2020-08-03 12:14 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    Which rocket would you take to Mars?










    Results (27 votes). Check out past polls.

    Notices?