Not hard-code text with NET::SMTP ?

Bush Dr has asked for the wisdom of the Perl Monks concerning the following question:

I'm trying to call an email script from another program (Tivoli). If I hard-code the text to send, it sends normally...However, if I try to pass a variable as the text it never sends the page. Here's a snippet of Sample code below:

 


open (PAGE, "<staging.log");
@lines = <PAGE>;
foreach $line (@lines)
{
$newline = $line;
}
close (PAGE);

#####  Sending Email
my $recipient1 = 'johnny@abc.net';
my $smtp = Net::SMTP->new('mailrelay.acme.com',
                    Hello => 'email.acme.com'
                    );

$smtp->mail ($ENV{USER});
$smtp->recipient($recipient1);
$smtp->data();
$smtp->datasend("$newline");
$smtp->datasend();
$smtp->quit;
[download]

$newline is the culprit. If I pass it as listed above, it doesn't work. If I replace the variable with static text it runs.........help!!

Title edit by tye

Comment on Not hard-code text with NET::SMTP ? Download Code

Replies are listed 'Best First'.
Re: NET::SMTP by gnangia (Scribe) on Aug 11, 2003 at 15:45 UTC
Try it this way `$smtp->data(); $smtp->datasend("To: $mailheaders{To}\n"); $smtp->datasend("From: $mailheaders{From}\n"); $smtp->datasend("Subject: $mailheaders{Subject}\n"); $smtp->datasend("Date: $smtpdate\n"); $smtp->datasend($message); $smtp->dataend();` [download] where $message contains text of the message	[reply] [d/l]
Re: NET::SMTP by Abigail-II (Bishop) on Aug 11, 2003 at 15:33 UTC
`$newline` will be the last line of `staging.log`, which you are getting in a very inefficient way. Is that what you want? Abigail	[reply] [d/l] [select]
Re: Re: NET::SMTP by Bush Dr (Initiate) on Aug 11, 2003 at 15:51 UTC
that's the way I've done it now. It will be the only line in that file. I'm using: `open (PAGE, "<staging.log");` [download] any ideas?	[reply] [d/l]
Re(3): NET::SMTP by elbie (Curate) on Aug 11, 2003 at 15:58 UTC
I suspect that staging.log is playing tricks on you, but having a blank line at the end of the file. You can always check if the contents of the current instance of $line is empty before you assign it to $newline. Something like this: `if( $line =~ /^\s*$/ ) { $newline = "Blank line."; } else { $newline = $line; }` [download] Or, better yet, you could play around with debug mode and step through the program as it runs. elbieelbieelbie	[reply] [d/l]
Re: Re: Re: NET::SMTP by sgifford (Prior) on Aug 11, 2003 at 16:28 UTC
If you're sure that's the only line in the file, a simpler and perhaps less error-prone method is to use: `$newline = join("",<PAGE>);` [download] which will read in all of the lines from the file and concatenate them into one string. In any case, printing out `$newline` as a debugging aid will probably help you track this problem down without sending a zillion messages.	[reply] [d/l] [select]
Re: Re: NET::SMTP by jonnyfolk (Vicar) on Aug 11, 2003 at 19:35 UTC
No one took the bait, so I will :) What would be a more efficient way of doing it?	[reply]
Re: NET::SMTP by Abigail-II (Bishop) on Aug 11, 2003 at 21:15 UTC
One way of doing it more efficiently: `while ($newline = <HANDLE>) {}` [download] It's very inefficient to first read in all the lines into an array, and then setting `$newline` to each entry of the array, ending at the last. If the file is big, you might want to read backwards from the end. Abigail	[reply] [d/l]


Think about Loose Coupling
	PerlMonks