Beefy Boxes and Bandwidth Generously Provided by pair Networks
Perl: the Markov chain saw

Re: Re: Re: Re: Checking Perl script on server

by snax (Hermit)
on Jul 30, 2003 at 16:01 UTC ( #279230=note: print w/replies, xml ) Need Help??

in reply to Re: Re: Re: Checking Perl script on server
in thread Checking Perl script on server

I can't speak directly to efficiency as it's hardly my specialty, but I would suggest a change to this chunk:
while($line = <F>) { for $hit ($line =~ /matchdata/gi) { push @files, $name; } } close F;
Logically it seems like you want to check to see if the file you're currently examining has data that needs to be updated (you're saving the filename in @files for later processing) -- but you're pushing the filename onto your list once for each match in the file! Once you find a match in a particular file you should (based on my understanding of your goal) (1) push the filename onto your to-be-processed stack, and then (2) move on to the next file. So:
while($line = <F>) { if ($line =~ /matchdata/i) { push @files, $name; last; } } close F;
Note that I dropped the global flag for the match operator, too -- you just want to know if there's something there, anywhere, to be fixed later, and then move on.

Naturally, if I misunderstand your goals this could be way off base :)

Log In?

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://279230]
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others pondering the Monastery: (4)
As of 2022-11-30 21:55 GMT
Find Nodes?
    Voting Booth?