Beefy Boxes and Bandwidth Generously Provided by pair Networks
Welcome to the Monastery
 
PerlMonks  

Re: Bad Module Code

by ihb (Deacon)
on Jul 12, 2003 at 15:18 UTC ( [id://273634]=note: print w/replies, xml ) Need Help??


in reply to Bad Module Code

You've been given many comments and suggestions, so I won't second them.

What I find most upsetting with the code though is that it doesn't localize FH and $_. That is bad, bad, bad. Forgetting to localize $_ is far too common. See Localizing $_ and while (<FH>) { ... }. (Is really: "Re: Re4: matching every occurrence of a regex") for a brief list of (core/common) modules that at that time didn't localize $_--potentially causing bugs in the user's program.

ihb

Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://273634]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others contemplating the Monastery: (5)
As of 2024-03-28 08:20 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found