Beefy Boxes and Bandwidth Generously Provided by pair Networks
Perl Monk, Perl Meditation

Re: Re: Re: Re: Reinvent a broken wheel?

by nysus (Vicar)
on Jul 08, 2003 at 22:02 UTC ( #272493=note: print w/replies, xml ) Need Help??

in reply to Re: Re: Re: Reinvent a broken wheel?
in thread Reinvent a broken wheel?

Well, when the module continutally tried to search http:/ instead of, that was a pretty big tip off that the code wasn't up to snuff. The problem is that he rolled his own instead of using the URI module. Also, when I looked at the guts of the code, the 'new' constructor was 90% of the body of the code. That didn't smell quite right to me either. Then, to pass arugments, he would use code like

sub _save_img { my ($self,$url,$img) = (shift,shift,shift,shift);

Finally the code was littered with numerous #hack comments.

I'm no expert mechanic true. But I do know that if the body is rusted and the interior is a filth pit (not that this code was THAT bad, mind you) there's a good chance the engine isn't worth repairing. I've seen enough professional code before and I know it when I see it. That doesn't mean I can write it.

$PM = "Perl Monk's";
$MCF = "Most Clueless Friar Abbot Bishop Pontiff";
$nysus = $PM . $MCF;
Click here if you love Perl Monks

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://272493]
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others wandering the Monastery: (6)
As of 2021-01-19 01:17 GMT
Find Nodes?
    Voting Booth?