Beefy Boxes and Bandwidth Generously Provided by pair Networks
Perl-Sensitive Sunglasses
 
PerlMonks  

Re: Reinvent a broken wheel?

by David Caughell (Monk)
on Jul 08, 2003 at 18:48 UTC ( #272385=note: print w/replies, xml ) Need Help??


in reply to Reinvent a broken wheel?

I think that this forum is probably the last place that someone would want to call a CPAN module poorly written or malfunctioning!

(especially before you contact the author)

Dave.

Replies are listed 'Best First'.
Re: Re: Reinvent a broken wheel?
by nysus (Vicar) on Jul 08, 2003 at 18:57 UTC
    Why? All I'm saying is that, in my opinion, his code doesn't appear to work well and is unnecessarily complicated. I mean, I don't have to contact George Lucas before I publish the fact that I think his last Star Wars movie sucked, do I?

    $PM = "Perl Monk's";
    $MCF = "Most Clueless Friar Abbot Bishop Pontiff";
    $nysus = $PM . $MCF;
    Click here if you love Perl Monks

      You referred to yourself as a "borderline newbie/intermediate." Are you really sure the code he wrote was of low quality or did he just use certain constructs and idioms that you're just not familiar or comfortable with yet?

      Either way, I as well would encourage you to go ahead and write your module, if for nothing other than the learning experience.

        Well, when the module continutally tried to search http:/www.nytimes.com instead of http://www.nytimes.com, that was a pretty big tip off that the code wasn't up to snuff. The problem is that he rolled his own instead of using the URI module. Also, when I looked at the guts of the code, the 'new' constructor was 90% of the body of the code. That didn't smell quite right to me either. Then, to pass arugments, he would use code like

        sub _save_img { my ($self,$url,$img) = (shift,shift,shift,shift);

        Finally the code was littered with numerous #hack comments.

        I'm no expert mechanic true. But I do know that if the body is rusted and the interior is a filth pit (not that this code was THAT bad, mind you) there's a good chance the engine isn't worth repairing. I've seen enough professional code before and I know it when I see it. That doesn't mean I can write it.

        $PM = "Perl Monk's";
        $MCF = "Most Clueless Friar Abbot Bishop Pontiff";
        $nysus = $PM . $MCF;
        Click here if you love Perl Monks

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://272385]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others chilling in the Monastery: (10)
As of 2021-01-21 23:37 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    Notices?