Beefy Boxes and Bandwidth Generously Provided by pair Networks
Perl: the Markov chain saw
 
PerlMonks  

Re: RFC US Region Module

by PodMaster (Abbot)
on Jul 06, 2003 at 13:27 UTC ( #271778=note: print w/replies, xml ) Need Help??


in reply to RFC US Region Module

In addition to what's already been said, I don't see you using any of Data::Dumper's functionality. Also, I think you should just inline the datastructures you're generating in sub "new". I see no point in reading from __DATA__ more than once if the data isn't changing.

MJD says "you can't just make shit up and expect the computer to know what you mean, retardo!"
I run a Win32 PPM repository for perl 5.6.x and 5.8.x -- I take requests (README).
** The third rule of perl club is a statement of fact: pod is sexy.

Replies are listed 'Best First'.
Re: Re: RFC US Region Module
by trs80 (Priest) on Jul 06, 2003 at 19:02 UTC
    The Data::Dumper was left over from initial debugging, I have removed it.

    Agreed on the __DATA__ issue. In fact you can't reread from __DATA__ without certain precautions. I have moved the while outside of the new method to avoid this issue. I do however prefer to keep the data in plain text rather then a data structure for reablility. Thanks for the feedback.

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://271778]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others imbibing at the Monastery: (6)
As of 2020-07-08 12:03 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found

    Notices?