Re: Show count before data output

Since you are printing the data inside of the while-loop, it's printed before the count-value. You told the programm to do.
A solution is to gather the lines in an array, and print them after the while-loop, (of course unless you are reading more lines than fit into memory):

use File::Find;
 
 sub fetcher
 {
     my($ct, @data) = (0,());
     if( $_ =~ /\.html?$/) {
       my $name = $File::Find::name;
       open ( F, $name ) or die "$!: $name\n";
        #while( $line = <F> ) 
        # {
        #    for $i ($line =~ /stuffhere)/gi ) {
        #              push(@data, "$i\n"); # gather the lines
    #     $ct++;
        #    }
        #}

    # since there is no requirement the lines need to match
        # why not
        local $/ = undef;
    @data = <F>;
        close F;
     }
     return($ct,\@data);
 }
my ($ct, $data) = find( \&fetcher, "/directory"  );

print @$data; 
print "\n\nTotal Count = $ct\n\n";
[download]

should do it. Note that I modified your loop, but provided a more proper solution below it.

Since you are reading in html-files, I wonder if some CPAN-Module might be of interest to you.

regards,
tomte

Update:Modified the code to slurp the file in.

Update II:fixed the CPAN-link.

Hlade's Law:

If you have a difficult task, give it to a lazy person --
they will find an easier way to do it.

Comment on Re: Show count before data output Download Code

Replies are listed 'Best First'.
Re: Re: Show count before data output by Anonymous Monk on Jun 23, 2003 at 19:30 UTC
Thanks, I tried as you suggested and got this message: `Use of uninitialized value at fet7a.pl line 28. Total Count =` [download] Here is what I have: `use File::Find; sub fetcher { my($ct, @data) = (0,()); if( $_ =~ /\.html?$/) { my $name = $File::Find::name; open ( F, $name ) or die "$!: $name\n"; while( $line = <F> ) { for $i ($line =~ /stuff/gi ) { push(@data, "$i\n"); # gather the lines $ct++; } } # since there is no requirement the lines need to match # why not local $/ = undef; @data = <F>; close F; } return($ct,\@data); } my ($ct, $data) = find( \&fetcher, "/directoryHere" ); print @$data; print "\n\nTotal Count = $ct\n\n";` [download]	[reply] [d/l] [select]
Re: Re: Re: Show count before data output by Tomte (Priest) on Jun 23, 2003 at 19:53 UTC
I should read posts more carefuly before answering, your use of File::Find was totaly unnoticed by me. You can't pass return values through the call of find, use a global variable instead, as you originaly did. Here a slightly modified version, that searches `use` lines in `.pl` files. use File::Find; my($ct, @data) = (0,()); sub fetcher { if( $_ =~ /\.pl?$/) { my $name = $File::Find::name; open ( F, $name ) or die "$!: $name\n"; my @lines = <F>; close(F); my @matches = grep(/^use/, @lines); push(@data, @matches); $ct += scalar(@matches); } } find( {wanted => \&fetcher, no_chdir => 1, }, "." ); print "\n\nTotal Count = $ct\n\n"; print @data; __END__ Total Count = 8 use strict; use WWW::Search::Tv::German::Tvtoday 1.02; use File::Find; use File::Basename; use HTML::TokeParser; use LWP::Simple; use LWP::Simple; use Net::POP3; [download] Notice that I slurp the file and use grep to find the matches, I think it looks more like perl this way. And by the way: I would realy like to know, for what purpose you wrote this code, as it seems to me, if you had posted that, someone could come up with a more proper solution, just a humble guess... Oh, and as a further note: proper, read: consistent, indenting of code is most welcome here ;-) regards, tomte Hlade's Law: If you have a difficult task, give it to a lazy person -- they will find an easier way to do it.	[reply] [d/l]


Think about Loose Coupling
	PerlMonks