http://qs321.pair.com?node_id=267960


in reply to Re: Re: Mandatory indenting
in thread Mandatory indenting

How does your CVS know the code hasnt been tidied and thus to reject? I personally tend to tidy code before I put it under source control, but have no automatic procedure for doing so. Id like to hear more.


---
demerphq

<Elian> And I do take a kind of perverse pleasure in having an OO assembly language...

Replies are listed 'Best First'.
Re: Re: Re: Re: Mandatory indenting
by Anonymous Monk on Jun 23, 2003 at 04:35 UTC

    tidy it again and see if it changes :)

      Doh. :-)

      rotfl ++Anonny!


      ---
      demerphq

      <Elian> And I do take a kind of perverse pleasure in having an OO assembly language...
        rotfl ++Anonny!

        Thanks, no matter how hard I try I can't seem to make it past level 1 ;-)

      An adaptation of this script might work in that regard. It was a shell script I hacked together to reformat occasionally as I worked on things. Given one or more files on the command line, it looks to see if there is a .tdy version of the file present (creating an empty one if not), checks if the current version and the .tdy version differ, and if so, performs a tidy (setting the lines 123 characters-personal preference), not replacing the original if a .ERR file was produced. The .tdy file was also left in place for future comparison.

      #!/bin/bash PERLTIDY='/usr/local/bin/perltidy -l 123 ' TOUCH=/bin/touch DIFF=/usr/bin/diff WC=/usr/bin/wc CP=/bin/cp if [ $# -gt 0 ] then echo Command line: $0 $@ for file in $@ do if [ ! -e $file.tdy ] then $TOUCH $file.tdy fi if [ `$DIFF -q $file $file.tdy | $WC -l` -gt 0 ] then $PERLTIDY $file if [ -e $file.ERR ] then echo Error detected-not replacing else $CP -v $file.tdy $file fi else echo Skipping $file - perltidy on file not necessary fi done else echo Usage: $0 filename fi

      Update (20 Jan 2004): Added absolute paths to utilities used, to prevent issues with pathing.

Re^4: Mandatory indenting
by atcroft (Abbot) on Jun 23, 2003 at 05:49 UTC

    I would suspect it would involve using an entry in the commitinfo administrative file, although I am not sure of the exact format of the entry, or if it would be necessary to involve a script calling PerlTidy, or if it could be done from PerlTidy itself.

    I find the idea intriguing, though, and would be interested in hearing more about it as well.

      I've often thought of setting up a tidy mirror. Basically mirror my entire site/lib and lib/ (and what I call /devlib) in tidied form. Also if statically generated it would be a nice resource for online somewhere. (The HTMLized ouput that is.)


      ---
      demerphq

      <Elian> And I do take a kind of perverse pleasure in having an OO assembly language...