Re^2: RFC: CGI::Tables (topicalize with for)

Or maybe

my $attrs = ref eq 'HASH' ? $_ : {} for shift @$data;
[download]

which I find a lot less clumsy. Update: was ref $_ before.

Makeshifts last the longest.

Comment on Re^2: RFC: CGI::Tables (topicalize with for) Download Code

Replies are listed 'Best First'.
Re^3: RFC: CGI::Tables (topicalize with for) by chip (Curate) on May 11, 2003 at 01:14 UTC
Absolutely; I often topicalize with `for`. But I'd also write "`ref $_`" as "`ref`" or "`ref()`" -- concision! -- Chip Salzenberg, Free-Floating Agent of Chaos	[reply] [d/l] [select]
Re^4: RFC: CGI::Tables (topicalize with for) by Aristotle (Chancellor) on May 11, 2003 at 02:19 UTC
I don't generally like `foo()` much for routines that operate on `$_`. In this case I added it because I'd've had to if I'd written `'HASH' eq ref ? $_ : {}` [download] as the question mark is then parsed as a pattern delimiter instead of as part of a ternary. I usually write my comparisons that way around. But here neither the parens nor the variable is necessary as the following `eq` is unambiguous as to its meaning. Makeshifts last the longest.	[reply] [d/l]
Re: Re^2: RFC: CGI::Tables (topicalize with for) by chip (Curate) on May 11, 2003 at 03:28 UTC
Oops! Your substitution is actually really broken, because when `$data[0]` isn't a HASH, it gets thrown away. This is a Bad Thing. I didn't notice it at first, which is also a Bad Thing. :-, -- Chip Salzenberg, Free-Floating Agent of Chaos	[reply] [d/l]
Re^4: RFC: CGI::Tables (oops) by Aristotle (Chancellor) on May 11, 2003 at 05:04 UTC
I knew full well about that, but didn't pay close enough attention to know it's undesired. Also a Bad Thing.. Makeshifts last the longest.	[reply]


Pathologically Eclectic Rubbish Lister
	PerlMonks