Beefy Boxes and Bandwidth Generously Provided by pair Networks
The stupid question is the question not asked
 
PerlMonks  

Re: profiling help

by l2kashe (Deacon)
on Apr 16, 2003 at 00:42 UTC ( [id://250744]=note: print w/replies, xml ) Need Help??


in reply to profiling help

A micro op that may save you time is to anchor your regex.. Which may or may not be possible.. I was thinking something along the line of say
.. snip .. if (/^hostname ([-\w]+) /) or if (/^(?:\s+|)hostname ([-\w]+) /)
or even better if its on a line all by itself as you can at either end of the string..

I know its not why you asked, but you arent testing to see whether or not your open was successful..
# old line open F, $path; # new line IMHO open(F, "$path") || die "Cant open $path: $!\n"; # or even open(F, "$path") || ( print "Cant open $path: $!\n" && next); # another small trim would be to do away with the interim # array and filename.. $filelist = "/var/adm/links/newrun/filelist"; for ( `cat $filelist` ) { chomp; open(F, "$_") || die "Cant open $_: $!\n"; while (<F>) { # anchor could apply here as well.. !/hostname/ ? next : chomp; # work on hostname lines here last; } close(F); print $hostname. " "; }
Just some rambling thoughts on the code..

MMMMM... Chocolaty Perl Goodness.....

Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://250744]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others romping around the Monastery: (3)
As of 2024-04-19 20:41 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found