http://qs321.pair.com?node_id=248375


in reply to Re: Can this be a 1 line or simpler regex?
in thread Can this be a 1 line or simpler regex?

Beautiful. Though, without knowing exactly why, that layout bugs me. I'd rather do 
s{([\t\n\r\f])}{ local $_= $1; tr[\t\n\r\f][tnrf]; "\\$_" }eg;

[download]
Shrug. :)

Makeshifts last the longest.

Replies are listed 'Best First'.
Re: Re^2: Can this be a 1 line or simpler regex?
by BrowserUk (Patriarch) on Apr 06, 2003 at 04:13 UTC

    Actually, I think I prefer your layout too--and I can't exactly put my finger on why either:)

    Examine what is said, not who speaks.
    1) When a distinguished but elderly scientist states that something is possible, he is almost certainly right. When he states that something is impossible, he is very probably wrong.
    2) The only way of discovering the limits of the possible is to venture a little way past them into the impossible
    3) Any sufficiently advanced technology is indistinguishable from magic.
    Arthur C. Clarke.
[reply]
Re: Re^2: Can this be a 1 line or simpler regex?
by diotalevi (Canon) on Apr 06, 2003 at 02:40 UTC

    Ew. That that sprinkles eval blocks all over. That's also suboptimal. The original poster had the best version already. I fixed my own code to be nearly similar except that it doesn't benefit from perl's ability to compile a static regex only once. Your code is a static regex but you're imposing eval {} at each match point.

    An entirely different route might be to do some code generation so that the common parts are written only once, eval blocks aren't sprinked all over the place and the world is good again. The only issue is that now its not pretty anymore.

    # Keep $escape somewhere or give it a proper name.
my $escape = eval "sub {\n".join("\n",map "    \$_[0] =~ s/\\$_/\\\\$_
+/g;", qw/t r n f/)."\n};";

$escape->( $text );

    [download]
[reply]
[d/l]
      you're imposing eval {} at each match point
      Sorry, no. You're confusing /e with /ee. There's no evaling with /e.

      Makeshifts last the longest.

[reply]

        Huh. I wouldn't have guessed. The first /e isn't an eval, any other /e's are eval string blocks with all of the $@ overwriting semantics.

[reply]

In Section Seekers of Perl Wisdom