good chemistry is complicated, and a little bit messy -LW |
|
PerlMonks |
Re: Re: Re: Simplifying code (Not obfuscation)by Molt (Chaplain) |
on Mar 04, 2003 at 11:35 UTC ( [id://240296]=note: print w/replies, xml ) | Need Help?? |
Your test is mixing two different kinds of conditional, the 'if' and the 'or' types.
If/Unless version:
Or version: Note the use of 'or' instead of ||. The only difference between them is their precendence, but as a result the 'or' doesn't need the braces round the assignment. Overall good coding style. Nice and readable. If all the code I had to do maintenance on was so readable I'd be a very happy bunny. Update: Changed the if to an unless since I totally messed up the logic. Oops. Thanks 2mths for pointing that out, shall try and engage brain earlier next time. Update: Fixed the missing ` problem. Thanks parv. Also updated brain to test all Perlmonks submissions to avoid silly mistakes like this in future.
In Section
Seekers of Perl Wisdom
|
|