http://qs321.pair.com?node_id=23923


in reply to Parsing a file one line at a time

Hi!

Actually you only need to do this: 

open(FILE1, $ARGV[0]) || die "Error: $!\n";
@lines = <FILE1>;

[download]
This evaluated <FILE1> in list-context, and thus the whole file will be put in the @lines-array, one entry per line (or whatever you have assigned to $/)

So then, why didn't your code work as you expected ? Well - the line 

@lines = $_;

[download]
assigns the variable $_ to the array @lines. You are declaring the contents of @lines each and every time through that loop. It's almost the same with variables: 
$foo = $_;

[download]
this also redeclares the contents of $foo every time it is evaluated. With scalars we usually use the . (dot) operator or string concat. operator to avoid redeclaring its content: 
$foo .= $_;

[download]
or: 
$foo = $foo . $_;

[download]
So, with arrays we have something similar: 
push @lines, $_;

[download]
That will add to @lines instead of redeclaring its contents.

Autark

Replies are listed 'Best First'.
RE: RE: Parsing a file one line at a time
by Anonymous Monk on Jul 23, 2000 at 21:08 UTC
    you (probably) might want to use some idomatic perl, its called 'slurp mode'. It means being able to take in (slurp) the whole file in one go, this is possible by temporarily 'undef'ining the File Seperator $\. 
    open(FILE1, $ARGV[0]) || die "Error: $!\n";
{
  local $/;          #value is restored at end this block
  undef $/;          #'slurp mode'
  @lines = <FILE1>;  #slurp all lines
}
#$/ is as back 'to normal', so nothing unexpected happens later

    [download]
    local is 'sometimes' the 'right' way.
[reply]
[d/l]
      Actually, "slurp" mode is used for reading the contents of a file into a scalar. You're using an array. If you assign a filehandle to an array, Perl just "understands" and reads the entire file into the array. This code works fine: 
      open(FILE1, $ARGV[0]) || die "Error: $!\n";
@lines = <FILE1>;

      [download]
      Cheers,
      Ovid
[reply]
[d/l]

In Section Seekers of Perl Wisdom