Re: Should We Have A "Red Flags" Area?

# clear and self documenting
( undef, undef, $user, $pass, $domain ) = split;
if ( $user eq 'foo' and $pass eq 'bar' ) { }

# obfuscated, requires looking at data to understand
@fields = split;
if ( $field[2] eq 'foo' and $field[3] eq 'bar' ) { }
[download]

For every thing TURN TURN there is a season LEARN LEARN and a time to every purpose under the heaven. A time to be born, and a time to die; a time to plant, and a time to pluck up that which is planted; a time to kill, and a time to heal; a time to break down, and a time to build up; a time to weep, and a time to laugh; a time to mourn, and a time to dance; a time to cast away stones, and a time to gather stones together; a time to embrace, and a time to refrain from embracing; a time to get, and a time to lose; a time to keep, and a time to cast away; a time to rend, and a time to sew; a time to keep silence, and a time to speak; a time to love, and a time to hate; a time of war, and a time of peace.

cheers

tachyon

s&&rsenoyhcatreve&&&s&n.+t&"$'$`$\"$\&"&ee&&y&srve&&d&&print

Comment on Re: Should We Have A "Red Flags" Area? Download Code

Replies are listed 'Best First'.

Re: Re: Should We Have A "Red Flags" Area?
by extremely (Priest) on Feb 17, 2003 at 19:04 UTC

($user, $fred, $hair, $thing) = split ...
[download]

The red flag is on code like:

($user1, $user2, $user3, $user4) = split ...
[download]

The "Red Flag" in both cases is not putting a numbered list of like items into an array. Putting a mix of different items into an array is very much a decision that needs to be made on a case by case basis. 99% of the time, the varX..varY case should be a list. It is a Red Flag that the person doesn't yet comprehend the array abstraction and is very much the same mistake as the hash abstraction error.

The example wasn't very clear thanks to you all abstracting "var" to mean "any word here" rather than the same word over and over with a numeral attached. (And yes, there are occasionally good reasons to do that but they are the 1%, not the 99.

Still, I don't see any need to point those Red Flags up. The people who don't get that far into Perl generally aren't going to read a Red Flags section of this site or any other site. :)

--
$you = new YOU;
honk() if $you->love(perl)

[reply]
[d/l]
[select]


The stupid question is the question not asked
	PerlMonks