http://qs321.pair.com?node_id=219312


in reply to "Commifying" a number

The closest that I can come, and I don't know if this fits the bill of being simpler, is this:

use strict; my $number = 1234567890; print STDOUT "In: $number\n"; my $reversed = reverse($number); print STDOUT "Reversed: $reversed\n"; my @array = split/(\d{3})/, $reversed; shift @array; print STDOUT "Array: '" . join ("' - '", @array) . "'\n"; my $out = join("", map { $_ eq '' ? ',' : reverse($_) } @array); print STDOUT "Out: " . reverse($out) . "\n"; exit 0;

This prints out:

In: 1234567890 Reversed: 0987654321 Array: '098' - '' - '765' - '' - '432' - '1' Out: 1234,567,890

Of course, this lends itself to a one-liner, and although I'm not sure if you can quite get there you can certainly reduce the number of lines. Also note that it falls flat on its face if you try to use a decimal or floating-point number.

Maybe printf/sprintf can do what you want more simply than this?

Update -- I got the right result by doing the following:

my $out = substr(reverse(join("", map { $_ eq "" ? '' : $_ . ',' } spl +it/(\d{3})/, reverse($number))), 1);

Readable? No. Usable? Barely. No while loop? Check.