Beefy Boxes and Bandwidth Generously Provided by pair Networks
Problems? Is your data what you think it is?
 
PerlMonks  

•Re: CryptoPad v2.00

by merlyn (Sage)
on Nov 29, 2002 at 21:22 UTC ( #216595=note: print w/replies, xml ) Need Help??


in reply to CryptoPad v2.00

From a code-review standpoint:
  • There's far too much cut-n-paste-n-slightly-modified code in this program. Any time the same sequence of three or four lines of code appears amidst some other code that varies only slightly, it should be a big warning sign. For example, suppose you wanted to change "Processing..." to "Working...". You'd have to edit that in half a dozen places. Factor it out!
  • Your chain of "if"-tests should be replaced by a simple hash pointing at the right subroutine to call. That strategy would probably help in the rest as well.

-- Randal L. Schwartz, Perl hacker
Be sure to read my standard disclaimer if this is a reply.

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://216595]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others pondering the Monastery: (7)
As of 2021-02-25 17:22 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found

    Notices?