What does this mean? Is there an error generated? Without any more info, I'll just shoot in the dark and guess that it says that you have an insecure PATH. To fix that, just add this line to the beginning of the program:

$ENV{PATH}='/bin:/usr/bin'; # wherever your ls exec lives
[download]

If that's not the problem, share the error message with us, and we'll probably be able to help. You can also try looking up the error in perldiag.

-- Dan

Thats fixed it. Cheers Is the method i am using ok? I'm just wondering if there is a better, more solid way of doing this? I am trying to keep clear of adding perl modules as my sysadmin doesn't allow it, but i think we are on perl 5.6.something so i am not sure what modues are included with that release. Thanks

i just added what you suggested and now i get
Insecure $ENV{BASH_ENV} while running with -T switch at ./add

Ok, that helps - try setting $ENV{BASH_ENV} then to the same path, or just to an empty string, and use the full path to ls:

$ENV{BASH_ENV} = '';
my @files = `/bin/ls`;
[download]

-- Dan

rdfield

foreach $file (glob '/var/log/accounts/*') { will allow you to remove 3 lines of code, including that pesky ls

--
Tommy
Too stupid to live.
Too stubborn to die.

use DirHandle;

my $dh = new DirHandle('/var/log/accounts/');
while (my $file = $dh->read()) {
    # do stuff
    ...
}
[download]

--
perl: code of the samurai

#! /usr/bin/perl -wT 
use strict; 
use warnings; 

my $dir = 'var/log/accounts';


opendir DIR, $dir or die "Cannot opendir $dir:$!\n"; 
my @files = grep !/^\.{1,2}$/,readdir DIR;
closedir DIR;

for (@files) 
{
    my $file = "$dir/$_";    
    open IN,$file or die "Cannot open $file:$!\n";
    while (<IN>)
    {
        next if not /,/;
        my ($fullname,$username,$password,$domain,$service,$email,$upd
+ates,$ip_addr) = split(/,/, $_);
      next if not $ip_addr;
        print "$fullname\t$username\t$password\t$domain\t$service\t$em
+ail\t$updates\t$ip_addr\n";
    }
    close IN;
}
[download]

-- Regards,
Helgi Briem
helgi AT decode DOT is

Just one last question (if anybody is still reading this node). Taint complains about using unlink $file; What are the alternatives to that? Insecure dependency in unlink while running with -T switch at ./addvir +tuser.pl

opendir D, "/var/log/accounts"; 
@file=readdir(D); 
closedir D;
[download]