You are opening a file, reading it's contents, and then altering those contents in memory. Your not operating on the file directly nor are you writing the changes back to the file. Solving these problems is left as an exercise to the reader, but your code shows enough competence that I imagine you'll fix it quickly. A suggestion though - if I were in this position, unless the filehandle object needed to stick around for other reasons (or maybe even if it did) I'd prolly use Tie::File. Check it out on the CPAN.

Light a man a fire, he's warm for a day. Catch a man on fire, and he's warm for the rest of his life. - Terry Pratchet

while (<$FRAME_FILE>) {
    s/$change_on/$change_off/g;
}
[download]

if(s/$change_on/$change_off/) {
   ...
}
[download]

Makeshifts last the longest.

To All Helpers:

Again thanks for all the help. I now saw what I did wrong and have a better understanding of the logic.

Also, thanks for the recommendation of TIE::FILE. It works great but unfortunately I'm not able to use it in my final program.

Well happy programming...

perl -pi -e 's/(FChangeBar )Yes/$1No/g' test.mif
[download]

jeffa

L-LL-L--L-LL-L--L-LL-L--
-R--R-RR-R--R-RR-R--R-RR
B--B--B--B--B--B--B--B--
H---H---H---H---H---H---
(the triplet paradiddle with high-hat)

Jeffa-

Thanks for your reply and help but how can I modify my existing program? The reason being is that the ending program won't be as a simple as I have it. There will be numerous changes throughout.

Again thanks :-)

erikharrison is dead on. In order for your existing program to work, you really have to open a temp file, write to it, then clob the first file by moving the temp file over the first file:

use strict;
use IO::File;

my $in  = IO::File->new;
my $out = IO::File->new;
my $change_on  = "FChangeBar Yes";
my $change_off = "FchangeBar No";  # hmmm, lower case c?


$in->open('test.mif') or die "can't read input";
$out->open('>tmp.mif') or die "can't write output";

while (<$in>) {
   s/$change_on/$change_off/g;
   print $out $_;
}

$in->close or die "can't close input";
$out->close or die "can't close output";

rename('tmp.mif','test.mif') or die "can't rename";
[download]

Here is a much cooler version that uses Tie::File:

use strict;
use Tie::File;

my @file;

tie @file, 'Tie::File', 'test.mif' or die "cannot tie file";

s/(FchangeBar )Yes/$1No/g for @file;
[download]

But, you might not be able to incorporate this into your ending program. At any rate, you are welcome and good luck! :)

jeffa

L-LL-L--L-LL-L--L-LL-L--
-R--R-RR-R--R-RR-R--R-RR
B--B--B--B--B--B--B--B--
H---H---H---H---H---H---
(the triplet paradiddle with high-hat)