Re: Somethings not rightwith my MySQL do()

Something else is probably wrong, this code seems "runable" to me. Check what is $cat before running the query. You should also consider using placeholders:

my $sql = 'UPDATE category SET name=? AND view_cats_prod=? AND descrip
+tion=? WHERE id=?'

my $y;
if (param('page') eq "yes") {
    $y = 'yes';
} else {
    $y = 'no';
}

$dbh->do($sql, undef, $cat, $y, $des, $id) ||
    die $dbh->errstr;
[download]

Tiago

Update: Without more information all I can do is toss wild guesses. Did you commit if you need to? Is the field of the right type for the value you are inserting?

Comment on Re: Somethings not rightwith my MySQL do() Download Code

Replies are listed 'Best First'.
Re: Re: Somethings not rightwith my MySQL do() by andrew (Acolyte) on Jul 20, 2002 at 01:24 UTC
nope plaholder do same-thing	[reply]
Re: Re: Re: Somethings not rightwith my MySQL do() by Fastolfe (Vicar) on Jul 20, 2002 at 01:36 UTC
Add some basic debugging code to your script that prints out the value of `$cat` (and any other variable) before using it. I would suspect that this variable is not being properly set prior to being used in this query. And note that the placeholder suggestion is also one of safety: if you are using variables that are provided by the user directly in your SQL, keep in mind that users can put single-quotes and SQL code in this variable and execute arbitrary queries against your database through insecure code like this. use strict and taint-checking (`perl -wT`) when dealing with potentially unsafe data and Perl will (usually) get your attention when you try and do something that someone else could exploit.	[reply] [d/l] [select]
A reply falls below the community's threshold of quality. You may see it by logging in.


Keep It Simple, Stupid
	PerlMonks