Greetings andrew,

Always use strict. Thereafter, I'd prepare the second query outside the while using a different name than your first. With DBI, you can have multiple queries running this way. Also, bind values (also known as placeholders) via DBI are your friend.

use strict;
my $sth_null = $dbh->prepare(q{
  SELECT id, name FROM category WHERE parent IS NULL
});
$sth->execute or die $dbh->errstr;

my $sth_parent = $dbh->prepare(q{
  SELECT id,name FROM category WHERE parent = ?
});

while ( my @slog = $sth_null->fetchrow_array ) {
  $sth_parent->execute($slog[0]) or die $dbh->errstr;
  my $rv = $sth_parent->rows;
  my $subs = $rv;

...
[download]

Using placeholders with your prepare and execute statements lets DBI deal with making sure quotes are handled correctly. It also makes for nicer looking code, IMHO.

-gryphon
code('Perl') || die;

$sth = $dbh->prepare("SELECT id,name FROM category WHERE parent IS NUL
+L");
 $sth->execute or die $dbh->errstr;

 while ( @slog = $sth->fetchrow_array ) {

    $sth2 = $dbh->prepare("SELECT id,name FROM category WHERE parent =
+ '$slog[0]'");
    $sth2->execute or die $dbh->errstr;
...
[download]

# get a hash ref keyed to id
my $data = $dbh->selectall_hashref(
    'select id, name, parent from category', 'id'
);
[download]

gav^