Beefy Boxes and Bandwidth Generously Provided by pair Networks
Keep It Simple, Stupid
 
PerlMonks  

RE: Warning: merlyn was a BAD MONK

by merlyn (Sage)
on Jun 14, 2000 at 20:52 UTC ( #18135=note: print w/replies, xml ) Need Help??


in reply to Warning: merlyn was a BAD MONK
in thread Odd file rename

So you'd rather have people copy t0mas's work and then get code that goes off into never-never land or triggers CERT warnings?

This is what peer review is about. t0mas posted code. I reviewed it. Sure, there's more than one way to do it, but this wasn't one of them.

-- Randal L. Schwartz, Perl hacker

Replies are listed 'Best First'.
RE: RE: Warning: merlyn was a BAD MONK
by Ozymandias (Hermit) on Jun 14, 2000 at 20:57 UTC
    Actually, no. I'd rather you be the kind of saint we all know you really are. As I said, you know more than I do; probably more than anyone here does. That doesn't mean +7 font tags are the right way to go. I'd rather you say that recursion the way t0mas did it causes problems with symlinks, and as a result you'd suggest using some other method. t0mas' method does work, though, right? If I were going to use it in some situation (entirely hypothetical) where symlinks weren't an issue, I might prefer to do it that way for some reason - and in that case, I'd rather have your suggestion on how to do it better. That's all I'm saying.

    - Ozymandias

      View source. It was +4, not +7. (I've since edited it to +1.) And the problem with such solutions (that use explicit recursion instead of File::Find) is that they are non-portable, are often harder to get right, and create a "bad meme" virus. These must be contained and innoculated, lest they inflict pain upon the innocent.

      -- Randal L. Schwartz, Perl hacker

        I won't disagree. I might feel that there's a time and a place for everything, even something that might in other cases be called bad code, but I'll defer to your greater wisdom and experience.

        If the post had originally had +1 text, or preferably no emphasis at all, and something like what you just said, I would never have replied the way I did or voted --.

        - Ozymandias

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://18135]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others rifling through the Monastery: (4)
As of 2020-12-02 07:56 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    How often do you use taint mode?





    Results (35 votes). Check out past polls.

    Notices?