Beefy Boxes and Bandwidth Generously Provided by pair Networks
Don't ask to ask, just ask
 
PerlMonks  

Re: Re: Find and Print Directory Names

by andrew (Acolyte)
on Jul 07, 2002 at 17:19 UTC ( #179995=note: print w/replies, xml ) Need Help??


in reply to Re: Find and Print Directory Names
in thread s and replace

Why does this only print out one direcotry
@alldir = finddir("$config{home}$user{site_id}"); print "@alldir"; sub finddir { $root = shift; chomp ( $root ); $root = $root . '/' unless ( $root =~ m|/$| ); local *DIR; opendir ( DIR, $root ); my @userfiles = sort grep !/^\.\.?\z/, readdir DIR; foreach $file (@userfiles) { next unless ( -d "$root$file" ); $dir = "$root$file"; $dir =~ s/^\Q$config{home}$user{site_id}\E//; push(@direct, $dir); finddir("$root$file"); } return "@direct"; }

Replies are listed 'Best First'.
Re(3): Find and Print Directory Names
by cjf (Parson) on Jul 07, 2002 at 17:29 UTC

    First off, Use strict warnings and diagnostics. It'll make debugging a lot easier.

    Secondly, try removing the        finddir("$root$file"); from within the foreach loop. You're exiting the loop after the first iteration.

    Update: Oops. Read that wrong. Hang on a sec.

    Update 2:

    my %config = ( home => '/home/cjf/' ); my %user = ( site_id => 'code' ); my @alldir = finddir("$config{home}$user{site_id}"); print $_, "\n" for @alldir; sub finddir { my $root = shift; chomp $root; $root = $root . '/' unless ( $root =~ m|/$| ); local *DIR; opendir DIR, $root or die $!; my @userfiles = sort grep !/^\.\.?\z/, readdir DIR; my @direct; foreach my $file (@userfiles) { next unless ( -d "$root$file" ); my $dir = "$root$file"; $dir =~ s/^\Q$config{home}$user{site_id}\E//; push(@direct, $dir); } return @direct; }

    That will return all directories in $config{home}$user{site_id} but not go into the sub directories. Is that what you're looking for?

      no I want to return all the direcotries is $config(home)$user{site_id}
        You really, really should consider File::Find (I see its already been suggested, but I think its worth mentioning out again).
        use File::Find; find (sub { print "$_\n" if -d; }, $dir);
Re: Re: Re: Find and Print Directory Names
by ehdonhon (Curate) on Jul 07, 2002 at 19:04 UTC

    The reason it only prints out one directory is that you are not pushing the results of your recursive calls to finddir into the @direct array.

    next unless ( -d "$root$file" ); $dir = "$root$file"; $dir =~ s/^\Q$config{home}$user{site_id}\E//; push(@direct, $dir); push(@direct, finddir("$root$file"));

Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://179995]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others browsing the Monastery: (2)
As of 2021-11-28 13:02 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found

    Notices?