Beefy Boxes and Bandwidth Generously Provided by pair Networks
There's more than one way to do things
 
PerlMonks  

Re: Help with my Coding Style - another chance to critique

by FoxtrotUniform (Prior)
on Jul 02, 2002 at 05:46 UTC ( #178768=note: print w/replies, xml ) Need Help??


in reply to Help with my Coding Style - another chance to critique

I'm not really well-versed in Perl CGI programming, so I don't have a hell of a lot to say. I like the fact that your routines are fairly short, and that your symbol names are well-chosen. My biggest complaint is that you don't tend to line up like tokens vertically (most noticeable in the $self->run_modes call in sub setup), but that's a minor issue. I'd be tempted to break up some of the longer subroutines even more, but that's just me.

--
The hell with paco, vote for Erudil!
:wq

Replies are listed 'Best First'.
Re: Re: Help with my Coding Style - another chance to critique
by rattusillegitimus (Friar) on Jul 02, 2002 at 05:57 UTC

    Thanks for the input. The tokens not lining up is mainly because I changed all my tabs to spaces before posting to keep the lines from wrapping quite as much. I'll go through the original source, though, and make sure everything is lined up as it should.

    I would be quite interested in seeing any suggestions you have for breaking up some of the longer routines.

    -rattus

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://178768]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others imbibing at the Monastery: (4)
As of 2020-11-24 07:20 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found

    Notices?