Don't ask to ask, just ask | |
PerlMonks |
Re: Some suggestions on coding style - a chance to critiqueby Sifmole (Chaplain) |
on Jun 26, 2002 at 15:39 UTC ( [id://177409]=note: print w/replies, xml ) | Need Help?? |
One note about style:
You might find it cleaner, and I believe it is quicker, if you group your print statements or use a "heredoc". You can do this as well with your print MAIL section. You have some pretty long parameter lists, you might want to consider named parameters. Get rid of temporary variables:
You use a lot of post-conditionals, and I tend to as well, but you may want to re-evaluate whether some of them make the code more difficult to read than others. A test is whether the condition or the result is "more important" and use that to determine which goes first.
Why bother passing in the references? Just return the scalar values:
And just to restate, use CGI; Hope this is useful.
In Section
Meditations
|
|