my @matches = grep { $file[$_] =~ /^\Q$storeline|\E/ } 0..$#file;
[download]

@matches = grep { /^\Q$storeline|\E/ } @file;
[download]

no_match($storeline), return unless @matches;
[download]

duped_ids($storeline), return if @matches > 1;
[download]

Eh, no,

    my @matches = grep { $file[$_] =~ /^\Q$storeline|\E/ } 0..$#file;
[download]

and

    my @matches = grep { /^\Q$storeline|\E/ } @file;
[download]

are not equivalent. The former grabs the indices of where matches occur, while the latter grabs the matches themselves. Without knowing more about the rest of the program, I'm not going to say which version should be preferred.

Abigail

In Sifmole's defense, they are equivalent in the context of the code given. Since the values within @matches are never explicitly used, it doesn't matter precisely what is in there, just how many entries there are.

This means, taking Sifmole's optimization one step further is possible:

my $matches = grep { /^\Q$storeline|\E/ } @file;

if ($matches > 1)
{
     duped_ids($storeline);
}
elsif (!$matches)
{
     no_match($storeline);
}
return;
[download]

What I mean is that while technically they are not equivalent, in this particular sub-section of the program, they could be considered functionally equivalent.

Admittedly, as you pointed out, there might be more code, but it's not posted here.

So right you are. My mistake.

Line 2:
Needs a $ at the start, stores the regex in a hash of non_matches unless there are matches in the @matches array.

Line 3:
Again needs a $ at the start. Stores the regex in a hash if there are duplicates.

It could be written nicer.. ;)

--

Brother Frankus.

¤

Line 2 and 3 start with subroutine calls (not hash elements), so they don't need a $ at the start.

-- 
Joost       downtime n. The period during which a system
            is error-free and immune from user input.
[download]

I'd like to point out that this fragment is from my Re: Help. Attribution of it and reference to its parent would have saved a lot of speculation and justifiable wrong turns in this thread. I did point out that the &no_match and &duped_id subs were up for grabs and could be used for error reporting. I'd expect duplicate ids in the database to be a fatal error, and no_match() to warn of bad input.

In my reply, the emphasis was on error handling, which had pretty much been ignored in AM's original code. Perhaps I should have just suggested one of the CSV modules.

++Abigail-II for clear analysis.

After Compline,
Zaxo

sub blah {
}
[download]

They are calls to subroutines. The code for the subroutines is not present in the code snippet you posted.

---------
1|cool.gif|aaa|yes|yes
3|biggrin.gif|:D|biggie|yes

5|tongue.gif|:p|tongue|yes
---------
[download]

sub set_del_yes {
$storeline = $q->param('id');

open(FILE, "info/smileset.txt");
@file = <FILE>;
close(FILE);

chomp @file;

my @matches = grep { $file[$_] =~ /^\Q$storeline|\E/ } 0..$#file;
no_match($storeline), return unless @matches;
duped_ids($storeline), return if @matches > 1;
undef($file[$matches[0]]);
delete($file[$matches[0]]);

print "Smiley set has been deleted!<br><br>
<a href=\"admin.cgi?pass=$pas&do=settings_set\">Smiley Set</a>";

open FLE, '>', 'info/smileset.txt' or die $!;
print FLE $_, $/ for @file;
close FLE or die $!;
}
[download]

Edit kudra, 2002-06-10 Fixed literal [ and friend

Title edit by tye

Change this:

print FLE $_, $/ for @file;
[download]

To this:

for ( @file ) {
    print FLE "$_\n" if /\S/; # must have at least one non-whitespace
}
[download]

Cheers,
Ovid

Join the Perlmonks Setiathome Group or just click on the the link and check out our stats.

That's because a delete $array [$indx] only changes the size of the array if you are deleting from the end. If you really want it gone, you would use splice, but splicing away lots of individual elements from a large array is costly (as each splice in general take time linear in the size of the array).

You could change your print to:

    defined ($_) && print FLE $_, $/ for @file;
[download]

unless you have undeleted, undefined elements in @file which you want to print. In that case, you could do something like:

    foreach (0 .. $#file) {
        print FLE $file [$_], $/ if exists $file [$_]
    }
[download]

Abigail