|
in reply to Re: UberSecure v1.5.2
in thread html/file security cgi [revisited]
Well, you certainly have pegged me.
I am definately a rookie, but eager to learn. This is only my second perl/cgi program. I do not know all of the modules available or even how to use them.. But I am learning through trial and error and that is why I decided to post my lame code here.
To get input, opinions and suggestions to better ways. If you can show me ways to improve this particular program to excellent perl code. I will learn from it and be able to apply this knowledge to my next attempt. Thanks
(btw) Uber is a german word meaning super
~UberDragon13 |
Re: UberSecure v1.5.2 comments
by cjf (Parson) on May 14, 2002 at 02:56 UTC
|
Hello, just a few suggestions to help you improve upon this code:
- use CGI or die; - A few reasons why you should use the CGI.pm module instead of rolling your own.
- Using strict.pm will save you a lot of time down the road.
- As I pointed out earlier, make sure to read up on security. If you only remember one thing, make sure it's Don't Trust User Input.
- Add the -w flag (or use warnings;) to enable warnings. They'll help you catch silly mistakes and reduce your debugging time.
For added points, remove the "Do not edit without permission." statement. If you're posting code to get advice on how to improve it, the least you can do is allow others to use and modify it.
Other minor annoyances:
- The title - "UberSecure" this script isn't. Not by any stretch of the imagination. When you're learning and unsure of a script's quality, better to stick with a different title.
- Version number - I'm curious where "Version 1.5.2" came from. This number shouldn't just be picked out of the air, it should be representative of the stability of the code. Read the Software Release Practice HOWTO for more details on good release practices.
Hope this helps and best of luck with your future postings :).
| [reply]
[d/l] |
|
