Beefy Boxes and Bandwidth Generously Provided by pair Networks
Syntactic Confectionery Delight
 
PerlMonks  

Re: Domain Disk space check

by Chmrr (Vicar)
on Apr 04, 2002 at 03:23 UTC ( [id://156551]=note: print w/replies, xml ) Need Help??


in reply to Domain Disk space check

Please do not use this ptime.pl It's rather ugly perl4 code in the first place, and you only call it in one place -- and in that case (&ctime(time)) it's equivilent to scalar localtime Except that scalar localtime doesn't have any of the bugs. ;>

There are only two other things which stick out at me, both of them at least partially stylistic. For one, variables start off being undefined so the = undef part of

my ($foo, $bar, @baz) = undef
is repetitive. The only other note is that the code could be made slightly tighter by scoping the variables a little tighter. For instance, both $drive and $computer can be scoped just to the loop they're used in:
foreach my $computer (@computerlist) { ... # yadda yadda yadda foreach my $drive (@drives) { ... } ... }

Other than those couple of nitpicks, the code looks to be rather handy.

perl -pe '"I lo*`+$^X$\"$]!$/"=~m%(.*)%s;$_=$1;y^`+*^e v^#$&V"+@( NO CARRIER'

Replies are listed 'Best First'.
Re: Re: Domain Disk space check
by Marza (Vicar) on Apr 04, 2002 at 23:06 UTC

    Thank you for the suggestions. I kind of debated on where to scope the vars. I changed them as you suggested.

    I removed the ptime script(I was trying things out).

    I also added an exclusion routine and a ping check.

Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://156551]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others making s'mores by the fire in the courtyard of the Monastery: (4)
As of 2024-03-29 08:09 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found