Please do not use this ptime.pl It's rather ugly perl4 code in the first place, and you only call it in one place -- and in that case (&ctime(time)) it's equivilent to scalar localtime Except that scalar localtime doesn't have any of the bugs. ;>
There are only two other things which stick out at me, both of them at least partially stylistic. For one, variables start off being undefined so the = undef part of
my ($foo, $bar, @baz) = undef
is repetitive. The only other note is that the code could be made slightly tighter by scoping the variables a little tighter. For instance, both $drive and $computer can be scoped just to the loop they're used in:
foreach my $computer (@computerlist) {
... # yadda yadda yadda
foreach my $drive (@drives) {
...
}
...
}
Other than those couple of nitpicks, the code looks to be rather handy.
perl -pe '"I lo*`+$^X$\"$]!$/"=~m%(.*)%s;$_=$1;y^`+*^e v^#$&V"+@( NO CARRIER'