Re: file case change

I cant seem to get this working. I have been trying for ages but with no succes. the results are printed below

#!/usr/bin/perl -w

BEGIN {
    $|=1;
    print "Content-type: text/html\n\n";
    use CGI::Carp('fatalsToBrowser');
}

use strict;
my $file;


my $path = '/home/costas/test';

opendir (DIR, $path) or die "Can't opendir: $!";

for (readdir DIR) {
print "$_<br>";
    rename("$path/$_", lc("$path/$_")) or print "Couldn't rename $file
+: $!\n";
}

closedir DIR;
[download]

Couldn't rename : Not a directory ..
Couldn't rename : Device or resource busy safdLLP.txT.txt
Couldn't rename : Permission denied safdLLPt.txT.txt
Couldn't rename : Permission denied
[download]

can anybody see why this is happening? I tried to add the path and it still doesnt work?

Comment on Re: file case change Select or Download Code

Replies are listed 'Best First'.
Re: Re: file case change by ChOas (Curate) on Mar 15, 2002 at 12:26 UTC
Okay: change `for (readdir DIR) { print "$_<br>"; rename("$path/$_", lc("$path/$_")) or print "Couldn't rename $file +: $!\n"; }` [download] to: `for (readdir DIR) { next if (/^\.{1,2}$/); print "$_<br>"; rename("$path/$_", lc("$path/$_")) or print "Couldn't rename $_: $ +!\n"; }` [download] GreetZ!, ChOas print "profeth still\n" if /bird\|devil/;	[reply] [d/l] [select]
Re: Re: Re: file case change by tachyon (Chancellor) on Mar 15, 2002 at 20:34 UTC
This is really bad code. First you lowercase the whole file path ensuring that any uppercase path will break this code (as when you lowercase it you will then try to write along a non existant path). Next you seem to have forgotten that '.' and '..' are not the only directories you might find. Finally you should never print unescaped arbitrary strings in HTML. cheers tachyon s&&rsenoyhcatreve&&&s&n.+t&"$'$`$\"$\&"&ee&&y&srve&&d&&print	[reply]
Re: Re: file case change by Caillte (Friar) on Mar 15, 2002 at 15:07 UTC
Changing: `rename("$path/$_", lc("$path/$_")) or print "Couldn't rename $file: $!\n";` To `rename("$path/$_", "$path" . lc("/$_")) or print "Couldn't rename $file: $!\n";` Would allow upper case letters in your path. This page is intentionally left justified.	[reply] [d/l] [select]


Don't ask to ask, just ask
	PerlMonks