http://qs321.pair.com?node_id=129844


in reply to Would you use 'goto' here?

Once in a while I've used something like
if (exists $commands{$command}) { my ($result) = eval "&$command"; ... }
to avoid the if ($command eq "foo") { &foo } elsif (...) thing. I think I picked it up from Jim Winstead

 - ask

-- 
ask bjoern hansen, http://ask.netcetera.dk/   !try; do();

Replies are listed 'Best First'.
Re: Re: Would you use 'goto' here?
by chromatic (Archbishop) on Dec 06, 2001 at 07:36 UTC
    eval string, from a mod_perl guy! I'd be shocked, if I didn't think you had a good reason. :)

    I'd still prefer subrefs, can, and maybe even some symbolic references with map:

    %commands = map { $_ => \&{ $_ } } keys %commands;

    Season to taste.

    Update: Not that eval is slow, but that eval string has some memory leaks not fixed until 5.8. That can be nasty in mod_perl.

      In a program that'll fork and run another program, do multiple dns lookups, open and read a handful of files, write to the network, wait for the network and much more? Sure, we can eval half the day1 and it won't make much difference if any at all.

       - ask

      1) No, of course not literally half the day. :-)

      -- 
      ask bjoern hansen, http://ask.netcetera.dk/   !try; do();
      
Re: Re: Would you use 'goto' here?
by blakem (Monsignor) on Dec 06, 2001 at 07:34 UTC
    Is there any reason why string eval is preferable to either one of these:
    { no strict 'refs'; $command->(); # OR &$command(); }

    -Blake