No such thing as a small change | |
PerlMonks |
Re (tilly) 1: Code review on script siteby tilly (Archbishop) |
on Nov 26, 2001 at 08:47 UTC ( [id://127488]=note: print w/replies, xml ) | Need Help?? |
I dislike this list. It misses too many important things. And takes too many picky positions on irrelevant details. For instance take the HERE doc suggestion. Personally I don't use HERE docs because I find that synchronizing them against my own indentation tends to be too fragile. Instead I use qq(). Am I therefore going to be docked? Other things are inappropriate for scripts. Using templating modules is great for websites, but for a script it adds a big dependency, forces you to break out and manage several files, and gives little useful return. As I like to say, every good thing you can do has a corresponding cost, and it is the job of good programmers to decide the tradeoffs. I remain to be convinced that adding that dependency is typically a good choice for a stand-alone script. And I am likewise unconvinced that adding the indirection of CGI HTML generation is good for code that you hope someone will learn from. And of course there is the commenting question. Well good programmers disagree strongly on whether or not to comment, let alone how to comment appropriately. That is a mine-field I would recommend leaving well alone. So what would a better list be? Well if I was trying to judge a stand-alone CGI script, my list of things to look at would go something like this:
In Section
Meditations
|
|