Re: Local::SiteRobot - a simple web crawling module

This was where my journey hit a stumbling block ... WWW::SimpleRobot didn't work!

Rather than partially reinvent a wheel, did you try to work with the author to figure out why it "didn't work"? And can you please explain what "didn't work" for you? I've used the module successfully, as have many hundreds of others.

"forking" a codebase should be considered carefully, otherwise the open source users as a community all lose.

-- Randal L. Schwartz, Perl hacker

Comment on Re: Local::SiteRobot - a simple web crawling module

Replies are listed 'Best First'.

Re: Re: Local::SiteRobot - a simple web crawling module
by rob_au (Abbot) on Nov 25, 2001 at 05:17 UTC

WWW::SimpleRobot

traverse

$object->pages

$object->urls

shift

@pages

Better than just reporting this to the author, I have submitted a fix patch which corrects this behaviour by pushing results into a separate array to the queue.

115a116
>     my @results;
150a152
>             push (@results, $page);
165,166c167,168
<     $self->{pages} = \@pages;
<     $self->{urls} = [ map { $_->{url} } @pages ];
---
>     $self->{pages} = \@results;
>     $self->{urls} = [ map { $_->{url} } @results ];
[download]

Note that I never meant for my little piece of code to be viewed as a code fork from WWW::SimpleRobot but rather just an additional available option.

Ooohhh, Rob no beer function well without!

[reply]
[d/l]
[select]


Come for the quick hacks, stay for the epiphanies.
	PerlMonks