Beefy Boxes and Bandwidth Generously Provided by pair Networks
Keep It Simple, Stupid
 
PerlMonks  

Use array instead of hash if all 'keys' are numeric

by pike (Monk)
on Nov 07, 2001 at 14:30 UTC ( [id://123791]=note: print w/replies, xml ) Need Help??


in reply to Finding missing elements in a sequence (code)

I have thought again about this problem, and it seems to me that you could have avoided this problem by using an array instead of a hash in your sub - this will get you the correct (numeric) comparison and save you one sort:

sub find_holes { my @list = @{ shift() }; @list = sort { $a <=> $b } @list; my $low = $list[0]; my $high = $list[-1]; my @notfound; @notfound[$low..$high] = ($low..$high); $notfound[$_] = 0 for @list; my @vacancies = grep {$_} @notfound; return \@vacancies; }
Since the value of the array index is not accessible in a simple for loop, I set the values of the array equal to the index and inverted the sense of the final grep, but otherwise everything is as it was. Note that this code will fail (just like the original one) if 0 is contained in the interval $low .. $high. But this can easily be fixed by setting the values we found to undef rather than 0 and checking for defined values in the final grep...

pike

Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://123791]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others drinking their drinks and smoking their pipes about the Monastery: (3)
As of 2024-04-18 11:14 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found